Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update function apps and app slots to correctly maintain content settings #15907

Merged
merged 4 commits into from
Mar 23, 2022
Merged

update function apps and app slots to correctly maintain content settings #15907

merged 4 commits into from
Mar 23, 2022

Conversation

jackofallops
Copy link
Member

fixes #15855

  • azurerm_linux_function_app - fixed update handling of app_settings for WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING
  • azurerm_linux_function_app_slot - fixed update handling of app_settings for WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING
  • azurerm_windows_function_app - fixed update handling of app_settings for WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING
  • azurerm_windows_function_app_slot - fixed update handling of app_settings for WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING

Tests passing:
image

@jackofallops jackofallops added this to the v3.0.0 milestone Mar 21, 2022
@jackofallops jackofallops requested review from tombuildsstuff and a team March 21, 2022 10:00
@jackofallops jackofallops self-assigned this Mar 21, 2022
katbyte
katbyte approved these changes Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from one minor comment LGTM 🏗️

internal/services/appservice/linux_function_app_slot_resource.go Outdated Show resolved Hide resolved
@fvdnabee
Copy link
Contributor

Verified that this PR (commit 85dc4c0) keeps the content settings after a resource update (for azurerm_windows_function_app). Thanks jack!

@jackofallops jackofallops force-pushed the b/function-app-settings-update-beta branch from 8bdb9c3 to 5c07792 Compare March 22, 2022 14:31
katbyte
katbyte approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jackofallops jackofallops merged commit f2bfa80 into main Mar 23, 2022
@jackofallops jackofallops deleted the b/function-app-settings-update-beta branch March 23, 2022 06:04
jackofallops added a commit that referenced this pull request Mar 23, 2022
@jackofallops
Update for #15907
506a251
@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees

@jackofallops jackofallops

Labels
service/app-service size/XL
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

[BUG] azurerm_windows_function_app removes Content Settings when updating resource
3 participants
@jackofallops @fvdnabee @katbyte